@bogorad please fix the ci tests, then we can get this in, thanks!

Pushed a0af04c (Fix Catch2 test setup ordering). This moves the BUILD_TESTING option before the Catch2 dependency setup, fixing the include(Catch) / catch_discover_tests configure failure.

Verified on this head:

• CircleCI connect_to_initial_version: passed
• CircleCI connect_with_jumphost: passed
• Local Nix dev-shell configure/build/CTest: 115/115 passed

GitHub Actions for this fork PR are still action_required and need maintainer/admin approval before they can run.

@bogorad I relaxed the approval so you should be able to fly-fix-fly without needing me to approve subsequent commits. You can also run the CI locally with nexos/act. Please get CI to pass then I can merge this

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.31%. Comparing base (34ae006) to head (6007de6).
⚠️ Report is 2 commits behind head on master.

@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files          71       71           
  Lines        5368     5368           
  Branches      501      501           
=======================================
  Hits         4687     4687           
  Misses        681      681           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@bogorad I asked AI to fix this pr (??) and it came up with this: https://github.com/MisterTea/EternalTerminal/pull/758/changes

currently testing on my machine, will post an update

Pushed 511e61680 to fix the original non-macOS CI failure.

Current state:

• The original NoVcpkg Build / build-novcpkg-ubuntu-latest-gcc11 failure is fixed.
• Ubuntu NoVcpkg, Ubuntu/Windows Vcpkg, Linux CI, CircleCI, Codecov, codespell, and formatting checks are green.
• The only remaining pending checks are macOS jobs.

I do not care about macOS support for this PR, so from my side the relevant CI is passing.

@copilot resolve the merge conflicts in this pull request

...and yet no flake/ci in master :)